Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify n_bootstraps docstring #549

Merged
merged 7 commits into from
Mar 20, 2025
Merged

Conversation

IAlibay
Copy link
Contributor

@IAlibay IAlibay commented Mar 7, 2025

The docstring seems to indicate Optional[int] but the code expects int. This clarifies the docstring a little bit by removing mentions of None.

Remove mentions of `None`.
@mrshirts
Copy link
Collaborator

mrshirts commented Mar 7, 2025

Yep, you're right, it was changed so that the default is zero, not none.

@mikemhenry
Copy link
Contributor

Since this doesn't use pre-commit, the linter is ran on the whole code base instead of just the changed files (or the diff) -- but it passes black so this LGTM

@mikemhenry mikemhenry merged commit 1eda979 into choderalab:master Mar 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants